Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce authenticated user validation in the refresh grant flow #2581

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Introduce authenticated user validation in the refresh grant flow #2581

wants to merge 7 commits into from
+590 −215

Conversation

DilshanSenarath
Copy link
Contributor

@DilshanSenarath DilshanSenarath commented Oct 1, 2024 •
edited
Loading

Description

Introduce validation logic to check if the user account is locked from the userstore. If locked, an error with an account lock message will be thrown. A configuration option has been added to enable this validation, which is disabled by default.

[oauth.token_renewal]
validate_authenticated_user_for_refresh_grant = true

Related Issue

Related PRs

@DilshanSenarath DilshanSenarath mentioned this pull request Oct 1, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.64%. Comparing base (04da85a) to head (00551b7).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...dentity/oauth/config/OAuthServerConfiguration.java 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2581      +/-   ##
============================================
- Coverage     56.12%   55.64%   -0.49%     
+ Complexity     8092     8047      -45     
============================================
  Files           632      632              
  Lines         46016    46252     +236     
  Branches       7520     7570      +50     
============================================
- Hits          25827    25736      -91     
- Misses        16472    16774     +302     
- Partials       3717     3742      +25
Flag Coverage Δ
unit 38.68% <93.87%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilshanSenarath DilshanSenarath mentioned this pull request Oct 11, 2024
Merged
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11324075240

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11324075240
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 14, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11324075240

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11363528076

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11363528076
Status: cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asha15 asha15 asha15 left review comments

@lashinijay lashinijay lashinijay left review comments

@shashimalcse shashimalcse shashimalcse left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DilshanSenarath @jenkins-is-staging @asha15 @lashinijay @shashimalcse